CRAYSAT-1948: Fix traceback in sat swap blade
#303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haasken-hpe
requested review from
shunr-hpe,
annapoorna-s-alt and
ethanholen-hpe
shunr-hpe
approved these changes
Dec 17, 2024
haasken-hpe
commented
Dec 17, 2024
haasken-hpe
commented
Dec 17, 2024
haasken-hpe
force-pushed
the
CRAYSAT-1948-fix-blade-swap
branch
from
60cf7c8 to
139cedd
Compare
ethanholen-hpe
approved these changes
Dec 18, 2024
Fix a traceback that occurs in `sat swap blade` when the node classes reported by HSM includes both "Mountain" and "Hill" for a single blade. This probably indicates some sort of configuration problem in HSM, but the behavior of `sat swap blade` is the same for both Mountain and Hill, so we can log a warning and proceed in this case. Test Description: Existing and new unit tests validate the new logic in `blade_class` property. Tested the `sat swap blade --action disable` command on baldar, which was exhibiting the issue where a single blade had some nodes reporting as "Hill" and some as "Mountain" in HSM. The command worked as expected.
haasken-hpe
force-pushed
the
CRAYSAT-1948-fix-blade-swap
branch
from
139cedd to
5cae513
Compare
|
The build of cray-sat from this branch was tested by Faiyaz on baldar today with the |
|
/backport release/3.33 |
|
Backporting into branch release/3.33 was successful. New PR: #308 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Fix a traceback that occurs in
sat swap bladewhen the node classes reported by HSM includes both "Mountain" and "Hill" for a single blade.This probably indicates some sort of configuration problem in HSM, but the behavior of
sat swap bladeis the same for both Mountain and Hill, so we can log a warning and proceed in this case.Issues and Related PRs
Testing
Tested on:
Test description:
Unit tested only so far.
Risks and Mitigations
Introduces some risk to the
sat swap bladecommand, but unit tests are pretty good for the modifiedblade_classproperty.Still needs to be tested on a system.
Pull Request Checklist