[Backport release/3.33] CRAYSAT-1948: Fix traceback in sat swap blade
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fix a traceback that occurs in `sat swap blade` when the node classes reported by HSM includes both "Mountain" and "Hill" for a single blade. This probably indicates some sort of configuration problem in HSM, but the behavior of `sat swap blade` is the same for both Mountain and Hill, so we can log a warning and proceed in this case. Test Description: Existing and new unit tests validate the new logic in `blade_class` property. Tested the `sat swap blade --action disable` command on baldar, which was exhibiting the issue where a single blade had some nodes reporting as "Hill" and some as "Mountain" in HSM. The command worked as expected. (cherry picked from commit 5cae513)
7 tasks
haasken-hpe
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #303