CRAYSAT-1913: Remove the ability to read VCS password from a file #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annapoorna-s-alt
force-pushed
the
CRAYSAT-1913-remove-vcs
branch
from
3360988 to
7c9300f
Compare
haasken-hpe
approved these changes
Oct 18, 2024
annapoorna-s-alt
force-pushed
the
CRAYSAT-1913-remove-vcs
branch
2 times, most recently
from
7522d54 to
42df761
Compare
shivaprasad-metimath
approved these changes
Oct 21, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Remove the ability to read VCS password from a file which is no longer necessary.
Issues and Related PRs
Resolves CRAYSAT-1913.
Merge this after Cray-HPE/python-csm-api-client#43
Testing
List the environments in which these changes were tested.
Tested on:
Yet to be tested on the system where it upgrades from CSM 1.5.x to 1.6.1
Test description:
Since we didn't get system to test the changes when CSM upgrade from 1.5.x to 1.6.0, Test this on update-cfs-config stage and prepare images stage when upgrading from CSM 1.5.x to 1.6.1 in future
Risks and Mitigations
Risk is low as we are removing only the code redundancy
Pull Request Checklist