-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAYSAT-1936: add ability to sort reports by multiple fields #295
Conversation
Output from testing on drax: https://gist.github.com/ethanholen-hpe/a4bc6a67dc7076ebb164c8b8b14644a4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My comments are minor.
I would suggest also testing behavior when given one or more unrecognized fields for --sort-by
. This relates to one of my comments on how we handle that as well.
Issue happening when running sat showrev: https://gist.github.com/ethanholen-hpe/445b90d6cc9349c52a764b510b0be5ae |
Testing and fix for issue: https://gist.github.com/ethanholen-hpe/c2017cb8402048ad9ff4a43dfb16e9fd this both tests and fixes the issue that @haasken-hpe mentioned where sort-by provides multiple fields that are invalid, I added testing for this as well |
c191615
to
88425cb
Compare
88425cb
to
bf10b01
Compare
/backport release/3.33 |
Backporting into branch release/3.33 was successful. New PR: #298 |
Summary and Scope
Added ability to sort reports by multiple fields
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.
Testing
Tested on:
Test description:
How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?
Pull Request Checklist