Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAYSAT-1936: add ability to sort reports by multiple fields #295

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ethanholen-hpe
Copy link
Contributor

@ethanholen-hpe ethanholen-hpe commented Dec 2, 2024

Summary and Scope

Added ability to sort reports by multiple fields

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Testing

Tested on:

  • drax
  • Local development environment

Test description:

How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

  • Were continuous integration tests run? If not, why? yes
  • Was upgrade tested? If not, why? yes
  • Was downgrade tested? If not, why? yes
  • Were new tests (or test issues/Jiras) created for this change? yes

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@ethanholen-hpe
Copy link
Contributor Author

@ethanholen-hpe ethanholen-hpe marked this pull request as ready for review December 4, 2024 21:24
Copy link
Contributor

@haasken-hpe haasken-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My comments are minor.

I would suggest also testing behavior when given one or more unrecognized fields for --sort-by. This relates to one of my comments on how we handle that as well.

docs/man/_sat-format-opts.rst Outdated Show resolved Hide resolved
docs/man/_sat-format-opts.rst Outdated Show resolved Hide resolved
sat/cli/showrev/parser.py Outdated Show resolved Hide resolved
sat/parsergroups.py Outdated Show resolved Hide resolved
sat/parsergroups.py Show resolved Hide resolved
sat/report.py Outdated Show resolved Hide resolved
sat/report.py Outdated Show resolved Hide resolved
sat/report.py Outdated Show resolved Hide resolved
tests/test_report.py Outdated Show resolved Hide resolved
tests/test_report.py Show resolved Hide resolved
@ethanholen-hpe
Copy link
Contributor Author

Issue happening when running sat showrev: https://gist.github.com/ethanholen-hpe/445b90d6cc9349c52a764b510b0be5ae

@ethanholen-hpe
Copy link
Contributor Author

ethanholen-hpe commented Dec 9, 2024

Testing and fix for issue: https://gist.github.com/ethanholen-hpe/c2017cb8402048ad9ff4a43dfb16e9fd

this both tests and fixes the issue that @haasken-hpe mentioned where sort-by provides multiple fields that are invalid, I added testing for this as well

@ethanholen-hpe ethanholen-hpe merged commit 5eac878 into main Dec 10, 2024
3 checks passed
@ethanholen-hpe ethanholen-hpe deleted the CRAYSAT-1936 branch December 10, 2024 21:43
@ethanholen-hpe
Copy link
Contributor Author

/backport release/3.33

Copy link

Backporting into branch release/3.33 was successful. New PR: #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants