CRAYSAT-1896: Fix sat bootprep to include False ims_require_dkms
#296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed `sat bootprep` to include the value of `ims_require_dkms` in the created CFS configurations, even when explicitly set to `False`. Test Description: Tested on rocket with a `bootprep` input file that defines a CFS configuration that contains two layers, one which sets the `ims_require_dkms` property to `True` and one which sets it to `False`. Verified that the resulting CFS configuration contained the value for the property in both layers. Tested in dry-run mode and regular mode for both CFS v2 and v3.
haasken-hpe
requested review from
annapoorna-s-alt,
ethanholen-hpe and
vinanti-p
haasken-hpe
force-pushed
the
CRAYSAT-1896-fix-false-values
branch
from
827dac3 to
3c04598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Fixed
sat bootprepto include the value ofims_require_dkmsin thecreated CFS configurations, even when explicitly set to
False.Issues and Related PRs
Testing
Tested on:
Test description:
Tested on rocket with a
bootprepinput file that defines a CFSconfiguration that contains two layers, one which sets the
ims_require_dkmsproperty toTrueand one which sets it toFalse.Verified that the resulting CFS configuration contained the value for
the property in both layers. Tested in dry-run mode and regular mode for
both CFS v2 and v3.
Risks and Mitigations
Low risk change to just support specifying false values in CFS configurations.
Pull Request Checklist