Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Compat for Gardens of the Dead, Undergarden, Unusual End & Deeper and Darker #7220

Open
wants to merge 4 commits into
base: mc1.20.1/dev
Choose a base branch
from

Conversation

VoidLeech
Copy link
Contributor

Adds/Expands data compat for the mods I add compat for in my treecutter PR:

  • Gardens of the Dead
  • Undergarden
  • Unusual End
  • Deeper and Darker
  • Quark
    Some of these have some compat built-in themselves but not complete.

Consists of:

  • Wood cutting recipes (GOTD, UG, DD)
  • Flower milling recipes (all)
  • Grass filling recipe (UG: deepturf)
  • Ore crushing recipes (UG)
  • Clay milling recipe (DD: sculk grime)
  • Bucket emptying recipe (UG)
  • Stone milling recipe (UG: depthrock -> pebbles (which are craftable into depthrock)
  • Horse armor crushing recipe (UUE)
  • Additions to Tags (fan_transparent, upright_on_belt, tree_attachments, modded_stripped_logs, modded_stripped_wood)

Concerns

  • Echoes some concerns from Data Compat for the Aether & Major Addons #7084 regarding milling recipes for flowers that don't have a dye-crafting recipe in the base mod, choice of output dyes, or not having milling recipes for (e.g.) grasses that don't have any other outputs in their loot tables.
  • Yes the blooming stem recipe produces 6 planks even though the stem isn't a full block. Crafting give 4 for which 6 is standard.
  • Contains the same modFlower helper and DatagenFluidStack additions as that PR (same commits)

@IThundxr IThundxr added the pr type: feature PR adds a new feature or changes an existing feature label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr type: feature PR adds a new feature or changes an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants