forked from Nukkit/Nukkit
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator #16
Open
ghost
wants to merge
59
commits into
Creeperface01:GT1.2
Choose a base branch
from
unknown repository
base: GT1.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Generator #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ice on ICE_FLATS (TEST)
Nether by Creeper, thanks bro
… get anthing. Fix more bugs & optimizations on level
- fixed zombies and villagers movement not updating - fixed dropped items "movement" lagging the living **** out of the server when not actually moving - fixed arrows not falling when the supporting block is removed - fixed knockback - fixed zombies + villagers being un-attackable after hitting them ... the list goes on
…ne can please fix Conflicts?
ghost
commented
Sep 22, 2017
src/main/java/cn/nukkit/Player.java
Outdated
@@ -1943,8 +1943,6 @@ protected void processLogin() { | |||
startGamePacket.yaw = (float) this.yaw; | |||
startGamePacket.pitch = (float) this.pitch; | |||
startGamePacket.seed = -1; | |||
startGamePacket.dimension = (byte) (this.level.getDimension().getId() & 0xff); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Creeperface01 probably you want re-add
@@ -1101,14 +1101,11 @@ public boolean entityBaseTick(int tickDiff) { | |||
} | |||
|
|||
if (this.inPortalTicks == 80) { | |||
EntityPortalEnterEvent ev = new EntityPortalEnterEvent(this, EntityPortalEnterEvent.PortalType.NETHER); // FIX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Creeperface01 Probably you want add and that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.