Enable suggest-override warning and fix instances

CrowCpp · Sep 1, 2024 · 5af2513 · 5af2513
1 parent 3ec06b0
commit 5af2513
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/cmake/compiler_options.cmake b/cmake/compiler_options.cmake
@@ -19,6 +19,7 @@ function(add_warnings_optimizations target_name)
         -Wall
         -Wextra
         -Wpedantic
+        -Wsuggest-override
         $<$<CONFIG:RELEASE>:-O2>
         $<$<CONFIG:DEBUG>:-O0 -g>
     )
@@ -29,6 +30,7 @@ function(add_warnings_optimizations target_name)
         -Wall
         -Wextra
         -Wpedantic
+        -Wsuggest-override
         $<$<CONFIG:RELEASE>:-O2>
         $<$<CONFIG:DEBUG>:-O0 -g -pg>
     )
@@ -38,6 +40,7 @@ function(add_warnings_optimizations target_name)
         -Wall
         -Wextra
         -Wpedantic
+        -Wsuggest-override
         $<$<CONFIG:RELEASE>:-O2>
         $<$<CONFIG:DEBUG>:-O0 -g -p -pg>
     )

diff --git a/include/crow/json.h b/include/crow/json.h
@@ -2033,7 +2033,7 @@ namespace crow // NOTE: Already documented in "crow/app.h"
                 return ret;
             }
 
-            std::string dump() const
+            std::string dump() const override
             {
                 static constexpr int DontIndent = -1;
 

diff --git a/include/crow/mustache.h b/include/crow/mustache.h
@@ -54,7 +54,7 @@ namespace crow // NOTE: Already documented in "crow/app.h"
             invalid_template_exception(const std::string& msg):
               msg("crow::mustache error: " + msg)
             {}
-            virtual const char* what() const throw()
+            virtual const char* what() const throw() override
             {
                 return msg.c_str();
             }