Multipart message view #862
Merged
+391
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fails compiling on macOS at least. |
|
Looks like merge_all.py tripped on the comment after |
|
Sorry, skipped the amalgamate build initially due to #865 |
gittiver
requested review from
mrozigor,
dranikpg,
The-EDev and
luca-schlecker
mrozigor
reviewed
Aug 12, 2024
mrozigor
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #838, here's the prototype of the multipart message with 'view' semantics.
It is written to allocate as little memory as possible (mainly vectors/maps for structuring message parts) and avoids copying the source request data, storing the views into it instead.
I've mostly copied the interface of the current multipart message, but made it non-
returnableto avoid very probable use-after-free footguns.