Merge pull request #534 from Crown-Commercial-Service/dependabot/bund…

…ler/rubocop-rspec-2.24.1

build(deps-dev): bump rubocop-rspec from 2.22.0 to 2.24.1

Gemfile

@@ -57,7 +57,7 @@ group :development, :test do
   gem 'rubocop', '~> 1.56.4'
   gem 'rubocop-performance', '~> 1.19.1'
   gem 'rubocop-rails', '~> 2.21.2'
-  gem 'rubocop-rspec', '~> 2.22.0', '>= 1.43.2' # or gem 'rubocop-minitest'
+  gem 'rubocop-rspec', '~> 2.24.1' # or gem 'rubocop-minitest'
   gem 'brakeman', '~> 6.0.1'
 end
 

Gemfile.lock

@@ -198,7 +198,7 @@ GEM
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
     parallel (1.23.0)
-    parser (3.2.2.3)
+    parser (3.2.2.4)
       ast (~> 2.4.1)
       racc
     pg (1.5.4)
@@ -299,9 +299,9 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.29.0)
       parser (>= 3.2.1.0)
-    rubocop-capybara (2.18.0)
+    rubocop-capybara (2.19.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.23.1)
+    rubocop-factory_bot (2.24.0)
       rubocop (~> 1.33)
     rubocop-performance (1.19.1)
       rubocop (>= 1.7.0, < 2.0)
@@ -310,7 +310,7 @@ GEM
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
-    rubocop-rspec (2.22.0)
+    rubocop-rspec (2.24.1)
       rubocop (~> 1.33)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
@@ -392,7 +392,7 @@ DEPENDENCIES
   rubocop (~> 1.56.4)
   rubocop-performance (~> 1.19.1)
   rubocop-rails (~> 2.21.2)
-  rubocop-rspec (~> 2.22.0, >= 1.43.2)
+  rubocop-rspec (~> 2.24.1)
   simplecov (~> 0.22.0, >= 0.16.1)
   spring (~> 4.1.1)
   spring-watcher-listen (~> 2.1.0)

spec/services/cognito/confirm_password_reset_spec.rb

@@ -198,8 +198,7 @@
       allow(Aws::CognitoIdentityProvider::Client).to receive(:new).with(region: 'supersecretregion').and_return(client)
       allow(client).to receive(:admin_get_user).and_return(cognito_user)
       allow(cognito_user).to receive(:user_attributes).and_return([attribute_type])
-      allow(attribute_type).to receive(:name).and_return('sub')
-      allow(attribute_type).to receive(:value).and_return('my-cognito-id')
+      allow(attribute_type).to receive_messages(name: 'sub', value: 'my-cognito-id')
       allow(client).to receive(:admin_list_groups_for_user)
     end
 

spec/services/cognito/create_user_from_cognito_spec.rb

@@ -47,8 +47,7 @@
       before do
         allow(client).to receive(:admin_get_user).and_return(cognito_user)
         allow(cognito_user).to receive(:user_attributes).and_return([attribute_type])
-        allow(attribute_type).to receive(:name).and_return('sub')
-        allow(attribute_type).to receive(:value).and_return('my-cognito-id')
+        allow(attribute_type).to receive_messages(name: 'sub', value: 'my-cognito-id')
         allow(client).to receive(:admin_list_groups_for_user)
         create_user_from_cognito.call
       end
@@ -94,8 +93,7 @@
 
     before do
       create_user_from_cognito.instance_variable_set(:@cognito_user, cognito_user)
-      allow(attribute_type).to receive(:name).and_return('sub')
-      allow(attribute_type).to receive(:value).and_return('my-cognito-id')
+      allow(attribute_type).to receive_messages(name: 'sub', value: 'my-cognito-id')
     end
 
     context 'when the user has been found' do

spec/services/cognito/sign_in_user_spec.rb

@@ -114,8 +114,7 @@
         let(:explicit_auth_flows) { ['USER_PASSWORD_AUTH'] }
 
         before do
-          allow(user_pool_client).to receive(:client_id).and_return('supersecretkey2')
-          allow(user_pool_client).to receive(:client_secret).and_return('supersecretkey1')
+          allow(user_pool_client).to receive_messages(client_id: 'supersecretkey2', client_secret: 'supersecretkey1')
           allow(client).to receive(:initiate_auth).and_return(auth_response)
           sign_in_user.call
         end