Merge pull request #531 from Crown-Commercial-Service/dependabot/bund…

…ler/rubocop-rails-2.21.2

build(deps-dev): bump rubocop-rails from 2.19.1 to 2.21.2

Gemfile

@@ -56,7 +56,7 @@ group :development, :test do
   gem 'rspec-rails', '~> 6.0.3', '>= 6.0.3'
   gem 'rubocop', '~> 1.56.4'
   gem 'rubocop-performance', '~> 1.19.1'
-  gem 'rubocop-rails', '~> 2.19.1', '>= 2.19.1'
+  gem 'rubocop-rails', '~> 2.21.2'
   gem 'rubocop-rspec', '~> 2.22.0', '>= 1.43.2' # or gem 'rubocop-minitest'
   gem 'brakeman', '~> 6.0.1'
 end

Gemfile.lock

@@ -306,7 +306,7 @@ GEM
     rubocop-performance (1.19.1)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.19.1)
+    rubocop-rails (2.21.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
@@ -346,7 +346,7 @@ GEM
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.7)
-    unicode-display_width (2.4.2)
+    unicode-display_width (2.5.0)
     web-console (4.2.1)
       actionview (>= 6.0.0)
       activemodel (>= 6.0.0)
@@ -391,7 +391,7 @@ DEPENDENCIES
   rspec-rails (~> 6.0.3, >= 6.0.3)
   rubocop (~> 1.56.4)
   rubocop-performance (~> 1.19.1)
-  rubocop-rails (~> 2.19.1, >= 2.19.1)
+  rubocop-rails (~> 2.21.2)
   rubocop-rspec (~> 2.22.0, >= 1.43.2)
   simplecov (~> 0.22.0, >= 0.16.1)
   spring (~> 4.1.1)

spec/services/cognito/confirm_password_reset_spec.rb

@@ -107,7 +107,7 @@
       end
 
       context 'and it has been pwned' do
-        let(:password) { PwnedPassword.all.pluck(:password).sample }
+        let(:password) { PwnedPassword.pluck(:password).sample }
 
         it 'is not valid' do
           expect(confirm_password_reset.valid?).to be false

spec/services/cognito/sign_up_user_spec.rb

@@ -252,7 +252,7 @@
       end
 
       context 'and it has been pwned' do
-        let(:password) { PwnedPassword.all.pluck(:password).sample }
+        let(:password) { PwnedPassword.pluck(:password).sample }
 
         it 'is not valid' do
           expect(sign_up_user.valid?).to be false