-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add chainsaw e2e tests support #3844
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
cc @jmckulk ;) |
Thanks for doing this! We have a story in our backlog to check out chainsaw and have added your pr to it! Were you able to use the |
Yup, it was all done with Only a few commands didn't pass (i fixed a bunch of bugs in BTW would you mind approving the workflows to check how it works ? |
pgDataVolume: | ||
pvcName: data-non-crunchy-cluster-0 | ||
directory: data | ||
postgresVersion: ${KUTTL_PG_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generate-kuttl
Make target in the workflow is used to fill out these variables with certain variables that might be different between tests. We would need to update/duplicate that target for chainsaw or figure out a different way to use variables.
@eddycharly Does chainsaw have a concept of variables or variable expansion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.1.3
introduced support to pass arbitrary values to tests and v0.1.4
will come with a solution to inject values in the resource manifests so basically no need for a generate step anymore :)
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Tests are run with kuttl
What is the new behavior (if this is a feature change)?
Tests are run with both chainsaw and kuttl
Other Information:
Chainsaw is similar to kuttl but a lot more flexible and actively maintained.
If you need more infos 👇