Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all of the app support translation #315

Open
guyluz11 opened this issue Oct 7, 2021 · 9 comments · Fixed by #402
Open

Not all of the app support translation #315

guyluz11 opened this issue Oct 7, 2021 · 9 comments · Fixed by #402
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/

Comments

@guyluz11
Copy link
Member

guyluz11 commented Oct 7, 2021

There is a big part of the app that does not support translation.

For the app to support translation there are 3 things that need to be added for each text string:

  1. Importing the easy_localization dependency
    import 'package:easy_localization/easy_localization.dart';
  2. Adding .tr() after the text string, for example 'hey' going te become 'hey'.tr(), and if this is Text widget it is also supported like this Text('Text support translation').tr().
  3. Add the new English translation key and value in the en-US.json.
  • Most of the string that needs to be added exists in the presentation folder so you can filter by it.

  • It is ok to do a partial pull request and not all add translations for everything at once.

@guyluz11 guyluz11 added enhancement New feature or request good first issue Good for newcomers labels Oct 7, 2021
@guyluz11 guyluz11 added the hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/ label Sep 29, 2022
@superiorsd10
Copy link
Contributor

@guyluz11 Can I work on this issue?

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 1, 2022

Yep

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 1, 2022

Thanks for the pr.

@superiorsd10
Copy link
Contributor

You're most welcome :)

@piyushkumar12111111
Copy link

Please assign this to me

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 4, 2022

@piyushkumar12111111 sure :)

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 8, 2022

Hi @piyushkumar12111111 I am removing you from Assignees but your pr will still be merged if it will be accepted

Thanks

@mufida1018
Copy link

Hello, please assign this to me

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 8, 2022

Just open pr for that @mufida1018 :) for now we may assign only big issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants