-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 315: adding translations for some files #402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes, everything else looks good.
lib/application/configure_new_cbj_comp/configure_new_cbj_comp_bloc.dart
Outdated
Show resolved
Hide resolved
@guyluz11 Okay! I'll be doing that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes
@@ -6,6 +6,7 @@ import 'package:cybear_jinni/domain/user/all_homes_of_user/all_homes_of_user_ent | |||
import 'package:cybear_jinni/domain/user/all_homes_of_user/all_homes_of_user_value_objects.dart'; | |||
import 'package:cybear_jinni/domain/user/i_user_repository.dart'; | |||
import 'package:dartz/dartz.dart'; | |||
import 'package:easy_localization/easy_localization.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed any more as we removed the translation
assets/translations/en-US.json
Outdated
"Turning_On_boiler": "Turning On boiler", | ||
"Turning_Off_boiler": "Turning Off boiler", | ||
"Waiting_for_user_to_get_connected_to_WiFi": "Waiting for user to get connected to WiFi", | ||
"allInSameRoom": "allInSameRoom", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed any more as we removed the translation
assets/translations/en-US.json
Outdated
"Waiting_for_user_to_get_connected_to_WiFi": "Waiting for user to get connected to WiFi", | ||
"allInSameRoom": "allInSameRoom", | ||
"Can't_add_unsupported_device": "Can't add unsupported device", | ||
"home": "home", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can keep that one
Thanks for the pr and happy Hacktoberfest 😁 |
#315
I've added the translation for text in some files in the
en-US.json
. They're in theapplication
folder.