createTag and getTag API #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ridhisjain <[email protected]>
cjchirag7
requested changes
Dec 12, 2020
Co-authored-by: Chirag Jain <[email protected]>
ridhishjain-zepto
force-pushed
the
tags
branch
from
263d659
to
efa0d87
Compare
NBNARADHYA
suggested changes
Dec 12, 2020
NBNARADHYA
suggested changes
Dec 12, 2020
There was a problem hiding this comment.
@ridhishjain I think getting tag by id is also necessary I guess. Like check if there is id in search string if so search it by id, otherwise check if search is available and search by search.
ridhishjain-zepto
force-pushed
the
tags
branch
from
efa0d87
to
a818ddc
Compare
NBNARADHYA
suggested changes
Dec 12, 2020
Co-authored-by: Chirag Jain <[email protected]>
ridhishjain-zepto
force-pushed
the
tags
branch
from
bdc99fe
to
314d431
Compare
NBNARADHYA
suggested changes
Dec 12, 2020
| const keyword = query.keyword || '' | ||
| const searchId = query.id || '' | ||
| pool.query( | ||
| `SELECT * FROM tags WHERE id LIKE ? AND name LIKE ?`, |
There was a problem hiding this comment.
Actually I meant to say:
let query = ``;
const depArr = [];
if(searchId) {
query += `SELECT * FROM tags WHERE id = ?`;
depArr.push(searchId);
} else if(keyword) {
query += `SELECT * FROM tags LIKE ?`;
depArr.push(keyword);
}
pool.query(query, depArr, (err, res) => {
...
})
There was a problem hiding this comment.
Yeah, that's much better !
There was a problem hiding this comment.
complexity will be same in both cases....
There was a problem hiding this comment.
Nope ! this would be a bit faster , as it doesn't have AND , OR in SQL query..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue at work: #60
API implemented:
createTagPOST /tagAdmin only: create a taggetTagGET /tag?search=keyword: search for a tag