Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verifyContestModerator middleware #82

Merged
merged 20 commits into from
Dec 15, 2020
Merged

verifyContestModerator middleware #82

merged 20 commits into from
Dec 15, 2020

Conversation

ridhishjain-zepto
Copy link
Collaborator

@ridhishjain-zepto ridhishjain-zepto commented Dec 15, 2020 •
edited
Loading

Issue at work: #60

resolves: #81

APIs covered:

  • createContest
    POST /contests/ Admin only: create a contest
  • updateContest
    POST /contests/:contest_id/update Moderator only: update contest
  • addModerator
    POST /contests/:contest_id/moderator Moderator only: Add moderator
  • removeModerator
    DELETE /contests/:contest_id/moderator Moderator only: remove moderator (creator can't be deleted)
  • addGroup
    POST /contests/:contest_id/:groups Moderator only: Add group
  • removeGroup
    DELETE /contests/:contest_id/groups Moderator only: remove group

cjchirag7
cjchirag7 approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@cjchirag7 cjchirag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ridhishjain-zepto
Copy link
Collaborator Author

I'll wait for @NBNARADHYA before merging 😆

NBNARADHYA
NBNARADHYA suggested changes Dec 15, 2020
View reviewed changes
server/models/contests/addGroup.js Outdated Show resolved Hide resolved
server/models/contests/addGroup.js Outdated Show resolved Hide resolved
server/models/contests/addModerator.js Outdated Show resolved Hide resolved
server/models/contests/addModerator.js Outdated Show resolved Hide resolved
server/models/contests/addModerator.js Outdated Show resolved Hide resolved
server/routes/contests/addGroup.js Outdated Show resolved Hide resolved
server/routes/contests/addModerator.js Outdated Show resolved Hide resolved
server/routes/contests/removeGroup.js Outdated Show resolved Hide resolved
server/routes/contests/removeModerator.js Outdated Show resolved Hide resolved
server/routes/contests/updateContest.js Outdated Show resolved Hide resolved
ridhishjain and others added 13 commits December 15, 2020 10:46
@ridhishjain @NBNARADHYA
Update server/routes/contests/updateContest.js
2f26358 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/routes/contests/removeModerator.js
e6d0d1d 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/routes/contests/removeGroup.js
8f833cb 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/routes/contests/addModerator.js
536a792 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/routes/contests/addGroup.js
5fb000e 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/models/contests/addGroup.js
e2ab09a 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/models/contests/addGroup.js
ff35922 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/models/contests/addModerator.js
0d9a7a2 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/models/contests/addModerator.js
c4b07fc 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/models/contests/addModerator.js
7809d5f 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/models/contests/removeGroup.js
099ac00 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/models/contests/removeGroup.js
d75a8b6 
Co-authored-by: NIKHIL BN <[email protected]>
@ridhishjain @NBNARADHYA
Update server/models/contests/updateContest.js
f39bd98 
Co-authored-by: NIKHIL BN <[email protected]>
NBNARADHYA
NBNARADHYA suggested changes Dec 15, 2020
View reviewed changes
server/models/contests/addGroup.js Outdated Show resolved Hide resolved
server/models/contests/addGroup.js Outdated Show resolved Hide resolved
server/models/contests/createContest.js Outdated Show resolved Hide resolved
NBNARADHYA
NBNARADHYA suggested changes Dec 15, 2020
View reviewed changes
server/models/contests/addGroup.js Outdated Show resolved Hide resolved
server/models/contests/addGroup.js Outdated Show resolved Hide resolved
NBNARADHYA
NBNARADHYA suggested changes Dec 15, 2020
View reviewed changes
server/models/contests/createContest.js Outdated Show resolved Hide resolved
server/models/database/index.js Outdated Show resolved Hide resolved
server/models/contests/createContest.js Outdated Show resolved Hide resolved
cjchirag7
cjchirag7 requested changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@cjchirag7 cjchirag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly, 2 changes are required:

  1. Release the pool connection in transaction, when any error occurs
  2. When the user who is sending the request doesn't have moderator access, appropriate error needs to be returned

server/models/contests/addGroup.js Show resolved Hide resolved
server/models/contests/addModerator.js Show resolved Hide resolved
server/models/contests/createContest.js Show resolved Hide resolved
server/models/contests/createContest.js Show resolved Hide resolved
server/models/contests/createContest.js Show resolved Hide resolved
server/models/contests/createContest.js Show resolved Hide resolved
server/models/contests/createContest.js Show resolved Hide resolved
server/models/contests/removeGroup.js Show resolved Hide resolved
server/models/contests/removeModerator.js Show resolved Hide resolved
cjchirag7
cjchirag7 approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@cjchirag7 cjchirag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean

NBNARADHYA
NBNARADHYA approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@NBNARADHYA NBNARADHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjchirag7 cjchirag7 merged commit 31d58c2 into Cyber-Labs:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjchirag7 cjchirag7 cjchirag7 approved these changes

@NBNARADHYA NBNARADHYA NBNARADHYA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verifyModerator middlware for contests
4 participants
@ridhishjain-zepto @NBNARADHYA @cjchirag7 @ridhishjain