Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create submission API #86

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

cjchirag7
Copy link
Collaborator

@cjchirag7 cjchirag7 commented Dec 19, 2020

For #60
Changes in brief

  • MySQL Tables modified to separate MCQ and Subjective Submissions
  • Create Submission API made supporting MCQ submission as well as subjective submissions
  • A minor fix in /contests/:contest_id/participate API to allow to participate only when a contest is active or upcoming

MySQL Tables modified to separate MCQ and Subjective Submissions
@cjchirag7 cjchirag7 marked this pull request as draft December 19, 2020 15:05
@cjchirag7 cjchirag7 force-pushed the submission-backend branch 3 times, most recently from 3bcae6f to cb61ecd Compare December 19, 2020 17:21
@cjchirag7
Copy link
Collaborator Author

In practise section, let us keep only coding questions. There's no meaning of keeping MCQ and subjective questions over there. As it wouldn't be possible to judge the responses of subjective question of a person who submitted long after the contest for practice?
Thoughts, @ridhishjain @NBNARADHYA

@cjchirag7 cjchirag7 marked this pull request as ready for review December 19, 2020 17:26
Copy link
Contributor

@NBNARADHYA NBNARADHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@NBNARADHYA NBNARADHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ridhishjain-zepto ridhishjain-zepto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ridhishjain-zepto ridhishjain-zepto merged commit e931328 into Cyber-Labs:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants