Merge pull request #217 from CybercentreCanada/hotfix/service_versions

Show all service versions, not just the first few
CybercentreCanada · Jun 24, 2021 · 5cd6337 · 5cd6337
2 parents 4bd4def + a59b585
commit 5cd6337
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/assemblyline_ui/api/v4/service.py b/assemblyline_ui/api/v4/service.py
@@ -368,8 +368,9 @@ def get_potential_versions(servicename, **_):
     """
     service = STORAGE.service_delta.get(servicename)
     if service:
-        return make_api_response([item.version for item in
-                                  STORAGE.service.search(f"id:{servicename}*", fl="version")['items']])
+        return make_api_response(
+            sorted([item.version for item in STORAGE.service.stream_search(f"id:{servicename}*", fl="version")],
+                   reverse=True))
     else:
         return make_api_response("", err=f"{servicename} service does not exist", status_code=404)
 

diff --git a/test/test_service.py b/test/test_service.py
@@ -106,7 +106,7 @@ def test_get_versions(datastore, login_session):
 
     service = random.choice(list(TEMP_SERVICES.keys()))
     resp = get_api_data(session, f"{host}/api/v4/service/versions/{service}/")
-    assert resp == ['3.3.0', '4.0.0']
+    assert resp == ['4.0.0', '3.3.0']
 
 
 # noinspection PyUnusedLocal