Using sets to dedup tags (DEV) #609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cccs-jh
requested review from
cccs-sgaron,
cccs-kevin,
cccs-rs and
gdesmar
and removed request for
cccs-kevin
gdesmar
requested changes
May 16, 2023
cccs-jh
force-pushed
the
add_tag_efficiency
branch
from
4a09da6 to
ab79ac6
Compare
In python the easiest way to get an insertion ordered set is to use a dictionary with no values (set to None). Since the original implementation kept tags in insertion order this implementation will not change the behaviour
cccs-jh
force-pushed
the
add_tag_efficiency
branch
from
d79bba2 to
cbb272b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.