Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move classes from package #501

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Move classes from package #501

merged 1 commit into from
Nov 22, 2024

Conversation

mr-zepol
Copy link
Contributor

@mr-zepol mr-zepol commented Sep 7, 2024

Solves #497

@mr-zepol mr-zepol requested a review from a team as a code owner September 7, 2024 16:07
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (dde0024) 6033 4403 72.98%
Head commit (08e03f8) 6033 (+0) 4403 (+0) 72.98% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#501) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro
Copy link
Member

nscuro commented Sep 13, 2024

This is also a breaking change, so let's include this in the next major version, together with #486.

@nscuro nscuro added this to the 10.0.0 milestone Sep 13, 2024
@nscuro nscuro added bug Something isn't working breaking change labels Sep 13, 2024
@mr-zepol mr-zepol requested a review from nscuro November 21, 2024 13:25
@nscuro nscuro merged commit 08a9448 into master Nov 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants