Secret Network Refactor #1788
Merged
Secret Network Refactor #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSaso
force-pushed
the
noah/secret-merge
branch
from
efb2f42 to
e8ae62f
Compare
NoahSaso
force-pushed
the
noah/secret-merge
branch
from
4a7cc47 to
9dee396
Compare
NoahSaso
force-pushed
the
noah/secret-merge
branch
from
9a460e2 to
90e4e6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors a bunch of stuff necessary to support Secret Network.
The main change is a new class-based client architecture that organizes DAOs, voting modules, and proposal modules and provides a common interface that can be implemented by different underlying DAO backends. The three types of DAOs the UI currently supports are our typical CosmWasm DAOs, Secret Network CosmWasm DAOs, and a chain's native x/gov governance system.