Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16: Create lbaf-viz interface #60

Merged
merged 58 commits into from
May 8, 2024
Merged

#16: Create lbaf-viz interface #60

merged 58 commits into from
May 8, 2024

Conversation

pierrepebay
Copy link
Contributor

@pierrepebay pierrepebay commented Oct 12, 2023 •
edited
Loading

Fixes: #16

@pierrepebay pierrepebay added the enhancement New feature or request label Oct 12, 2023
@pierrepebay pierrepebay self-assigned this Oct 12, 2023
@pierrepebay pierrepebay linked an issue Oct 12, 2023 that may be closed by this pull request
Generate visualization in vt-tv from Python bindings #16
Closed
lifflander
lifflander reviewed Nov 7, 2023
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@pierrepebay @cwschilly
#16: bindings: Lay out vizualizer binding structure and build system
cdb5ff0
@pierrepebay @cwschilly
#16: bindings: Continue binding setup
d78a627
@pierrepebay @cwschilly
#16: bindings: Try pip build and PyPI publish from CI
abb6f9c
@pierrepebay @cwschilly
#16: bindings: Fix publishing target to testPyPI
2d96c45
@pierrepebay @cwschilly
#16: bindings: Fix typo
230cb0b
@pierrepebay @cwschilly
#16: bindings: Fix typo
4868099
@pierrepebay @cwschilly
#16: bindings: Try buidling python package with cibuildwheel
c5cd288
@pierrepebay @cwschilly
#16: bindings: Fix nanobind include getter
8679d68
@pierrepebay @cwschilly
#16: bindings: Fix cpp file name in setup.py
4af066d
@pierrepebay @cwschilly
#16: bindings: Specify cmake build in setup.py
008e79b
@pierrepebay @cwschilly
#16: bindings: Continue cmake build backend for setup.py
e3accd1
@pierrepebay @cwschilly
#16: bindings: complete setup for local pip install of binded vttv pa…
c10c422 
…ckage
@pierrepebay @cwschilly
#16: bindings: Specify package in init file
068bab7
@pierrepebay @cwschilly
#16: bindings: Add a bit more functionality to binded function
563b1e9
@pierrepebay @cwschilly
#16: bindings: Specify build directory in setup.py
5f44dab
@pierrepebay @cwschilly
#16: bindings: Switch to modern python package build method and clean…
8527bab 
… up usage
@pierrepebay @cwschilly
#16: bindings: Update README to describe python binding build
f74f58e
@pierrepebay @cwschilly
#16: readme: fix subtitle
ac5e194
@pierrepebay @cwschilly
#16: bindings: Add initial python bindings CI testing
6bf84d0
@pierrepebay @cwschilly
#16: bindings: Fix testing CI
2b3b38f
@pierrepebay @cwschilly
#16: bindings: Fix pip install directory in CI testing
c87c921
@pierrepebay @cwschilly
#16: bindings: Specify compiler for cmake in CI testing
694b5a5
@pierrepebay @cwschilly
#16: bindings: Fix VTK build path in CI testing
11b75b3
@pierrepebay @cwschilly
#16: bindings: Fix conda environment initialization before CI testing
4210bf2
@cwschilly cwschilly force-pushed the 16-create-lbaf-viz-interface branch from c370ee2 to 887fb05 Compare April 9, 2024 14:04
@cwschilly
Copy link
Contributor

We're going to pause the work on CI for now and pick it up in a separate PR

@pierrepebay pierrepebay marked this pull request as ready for review April 26, 2024 14:30
lifflander
lifflander requested changes May 1, 2024
View reviewed changes
bindings/python/CMakeLists.txt Outdated Show resolved Hide resolved
bindings/python/tv.cc Show resolved Hide resolved
bindings/python/tv.cc Outdated Show resolved Hide resolved
bindings/python/tv.h Outdated Show resolved Hide resolved
ci/build-and-test-bindings.dockerfile Show resolved Hide resolved
src/vt-tv/render/render.cc Outdated Show resolved Hide resolved
src/vt-tv/render/render.cc Outdated Show resolved Hide resolved
lifflander
lifflander approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pierrepebay pierrepebay merged commit 97933f4 into master May 8, 2024
6 checks passed
@cwschilly cwschilly deleted the 16-create-lbaf-viz-interface branch May 10, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwschilly cwschilly cwschilly left review comments

@lifflander lifflander lifflander approved these changes

Assignees

@pierrepebay pierrepebay

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate visualization in vt-tv from Python bindings
3 participants
@pierrepebay @cwschilly @lifflander