#1830: lb: make getModeledValue const

DARMA-tasking · Oct 13, 2022 · 7573b94 · 7573b94
1 parent 8decfca
commit 7573b94
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/src/vt/vrt/collection/balance/temperedlb/temperedlb.cc b/src/vt/vrt/collection/balance/temperedlb/temperedlb.cc
@@ -1358,7 +1358,7 @@ void TemperedLB::migrate() {
   vtAssertExpr(false);
 }
 
-TimeType TemperedLB::getModeledValue(const elm::ElementIDStruct& obj) {
+TimeType TemperedLB::getModeledValue(const elm::ElementIDStruct& obj) const {
   return load_model_->getModeledLoad(
     obj, {balance::PhaseOffset::NEXT_PHASE, balance::PhaseOffset::WHOLE_PHASE}
   );

diff --git a/src/vt/vrt/collection/balance/temperedlb/temperedlb.h b/src/vt/vrt/collection/balance/temperedlb/temperedlb.h
@@ -124,7 +124,7 @@ struct TemperedLB : BaseLB {
   ElementLoadType::iterator selectObject(
     LoadType size, ElementLoadType& load, std::set<ObjIDType> const& available
   );
-  virtual TimeType getModeledValue(const elm::ElementIDStruct& obj);
+  virtual TimeType getModeledValue(const elm::ElementIDStruct& obj) const;
 
   void lazyMigrateObjsTo(EpochType epoch, NodeType node, ObjsType const& objs);
   void inLazyMigrations(balance::LazyMigrationMsg* msg);

diff --git a/src/vt/vrt/collection/balance/temperedwmin/temperedwmin.cc b/src/vt/vrt/collection/balance/temperedwmin/temperedwmin.cc
@@ -123,7 +123,7 @@ std::vector<NodeType> TemperedWMin::getPotentialRecipients() const {
   return nodes;
 }
 
-TimeType TemperedWMin::getModeledValue(const elm::ElementIDStruct& obj) {
+TimeType TemperedWMin::getModeledValue(const elm::ElementIDStruct& obj) const {
   vtAssert(
     theLBManager()->getLoadModel().get() == load_model_ptr,
     "Load model must not change"

diff --git a/src/vt/vrt/collection/balance/temperedwmin/temperedwmin.h b/src/vt/vrt/collection/balance/temperedwmin/temperedwmin.h
@@ -64,8 +64,6 @@ struct TemperedWMin : TemperedLB {
   void inputParams(balance::ConfigEntry* config) override;
 
 protected:
-  TimeType getModeledValue(const elm::ElementIDStruct& obj) override;
-
   /**
    * Allow migration when there are objects to migrate and other ranks are known
    */
@@ -79,6 +77,7 @@ struct TemperedWMin : TemperedLB {
    */
   bool isUnderloaded(LoadType load) const override { return true; }
 
+  TimeType getModeledValue(const elm::ElementIDStruct& obj) const override;
   std::vector<NodeType> getPotentialRecipients() const override;
 
 private: