Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove concept of under/overloaded from TemperedWMin #1830

Open
nlslatt opened this issue May 25, 2022 · 0 comments · May be fixed by #1860
Open

Remove concept of under/overloaded from TemperedWMin #1830

nlslatt opened this issue May 25, 2022 · 0 comments · May be fixed by #1860
Assignees
@cz4rs
Labels
type: task

Comments

@nlslatt
Copy link
Collaborator

nlslatt commented May 25, 2022

What Needs to be Done?

The implementation of the total work algorithm has been split into multiple issues, starting with #1672 and then continuing with this issue.

TemperedLB only allows underloaded ranks (those with less than the average load) to initiate the information propagation stage (see existing code comments Underloaded start the round and Underloaded start the first round, which are in two different implementations of the inform stage). TemperedWMin, on the other hand, has no concept of underloaded or overloaded ranks, and should allow all ranks to initiate the information propagation stage (right, @ppebay?). Make code changes to allow these two load balancers to behave differently in this regard.

TemperedLB also restricts potential recipients of work to ranks that are underloaded (or, in some modes, even sufficiently underloaded). Allow all ranks to be considered as potential recipients of work for TemperedWMin (right, @ppebay?) when building the CMF.
@nmm0 nmm0 mentioned this issue Jun 7, 2022
Open
cz4rs added a commit that referenced this issue Jun 17, 2022
@cz4rs
#1830: extract TemperedLB::clear
f1695a4
cz4rs added a commit that referenced this issue Jun 20, 2022
@cz4rs
#1830: extract TemperedLB::clear
2ba4365
cz4rs added a commit that referenced this issue Jun 22, 2022
@cz4rs
#1830: extract TemperedLB::clear
6dc081b
cz4rs added a commit that referenced this issue Jun 22, 2022
@cz4rs
#1830: extract more helper methods
d799c10
cz4rs added a commit that referenced this issue Jun 22, 2022
@cz4rs
#1830: extract more helper methods
728e2b3
cz4rs added a commit that referenced this issue Jun 22, 2022
@cz4rs
#1830: make getModeledWork const
5db9e38
cz4rs added a commit that referenced this issue Jun 22, 2022
@cz4rs
#1830: extract TemperedLB::clearDataStructures
afa4669
cz4rs added a commit that referenced this issue Jun 22, 2022
@cz4rs
#1830: extract more helper methods
413f98c
cz4rs added a commit that referenced this issue Jun 22, 2022
@cz4rs
#1830: make getModeledWork const
d8c4387
cz4rs added a commit that referenced this issue Jun 24, 2022
@cz4rs
#1830: extract TemperedLB::clearDataStructures
1a8bd84
cz4rs added a commit that referenced this issue Jun 24, 2022
@cz4rs
#1830: extract more helper methods
2f4b33b
cz4rs added a commit that referenced this issue Jun 24, 2022
@cz4rs
#1830: make getModeledWork const
6ae99d9
cz4rs added a commit that referenced this issue Jun 27, 2022
@cz4rs
#1830: lb: extract helper methods in TemperedLB
22b6490
cz4rs added a commit that referenced this issue Jun 27, 2022
@cz4rs
#1830: make getModeledWork const
bb5767c
cz4rs added a commit that referenced this issue Jun 27, 2022
@cz4rs
#1830: lb: extract helper methods in TemperedLB
dd30ab2 
- extract helper methods and add overloads for TemperedWMin
- remove redundant code
- remove unused member variable
cz4rs added a commit that referenced this issue Jun 27, 2022
@cz4rs
#1830: make getModeledWork const
d2f2f51
@cz4rs cz4rs linked a pull request Jun 27, 2022 that will close this issue
Draft
cz4rs added a commit that referenced this issue Jun 29, 2022
@cz4rs
#1830: lb: extract helper methods in TemperedLB
390f3eb 
- extract helper methods and add overloads for TemperedWMin
- remove redundant code
- remove unused member variable
cz4rs added a commit that referenced this issue Jun 29, 2022
@cz4rs
#1830: make getModeledWork const
7ac1889
cz4rs added a commit that referenced this issue Jun 29, 2022
@cz4rs
#1830: lb: extract helper methods in TemperedLB
65d0247 
- extract helper methods and add overloads for TemperedWMin
- remove redundant code
- remove unused member variable
cz4rs added a commit that referenced this issue Jun 29, 2022
@cz4rs
#1830: make getModeledWork const
53115ed
cz4rs added a commit that referenced this issue Jun 29, 2022
@cz4rs
#1830: TemperedWMin: allow all nodes to be potential recipients of work
6a85c17
cz4rs added a commit that referenced this issue Jun 29, 2022
@cz4rs
#1830: TemperedWMin: allow all nodes to be potential recipients of work
cc5dc58
cz4rs added a commit that referenced this issue Jun 29, 2022
@cz4rs
#1830: update .clang-format
d863bd3
cz4rs added a commit that referenced this issue Jul 8, 2022
@cz4rs
#1830: lb: extract helper methods in TemperedLB
5317df6 
- extract helper methods and add overloads for TemperedWMin
- remove redundant code
- remove unused member variable
cz4rs added a commit that referenced this issue Jul 8, 2022
@cz4rs
#1830: make getModeledWork const
6b0a315
cz4rs added a commit that referenced this issue Jul 8, 2022
@cz4rs
#1830: TemperedWMin: allow all nodes to be potential recipients of work
1822dfb
cz4rs added a commit that referenced this issue Oct 13, 2022
@cz4rs
#1830: TemperedWMin: pretend all nodes are underloaded
8decfca
cz4rs added a commit that referenced this issue Oct 13, 2022
@cz4rs
#1830: lb: make getModeledValue const
7573b94
cz4rs added a commit that referenced this issue Oct 19, 2022
@cz4rs
#1830: lb: extract helper methods in TemperedLB
660e6bc 
- extract helper methods and add overloads for TemperedWMin
- remove redundant code
- remove unused member variable
cz4rs added a commit that referenced this issue Oct 19, 2022
@cz4rs
#1830: TemperedWMin: allow all nodes to be potential recipients of work
d50c05f
cz4rs added a commit that referenced this issue Oct 19, 2022
@cz4rs
#1830: update .clang-format
e45ee3c
cz4rs added a commit that referenced this issue Oct 19, 2022
@cz4rs
#1830: remove duplicated struct
18fc6e0
cz4rs added a commit that referenced this issue Oct 19, 2022
@cz4rs
#1830: TemperedWMin: exclude current node from potential recipients
b3474b7
cz4rs added a commit that referenced this issue Oct 19, 2022
@cz4rs
#1830: TemperedWMin: provide canMigrate override
e91277c
cz4rs added a commit that referenced this issue Oct 19, 2022
@cz4rs
#1830: TemperedWMin: pretend all nodes are underloaded
941a24f
cz4rs added a commit that referenced this issue Oct 19, 2022
@cz4rs
#1830: lb: make getModeledValue const
0228e8a
cz4rs added a commit that referenced this issue Oct 19, 2022
@cz4rs
#1830: Revert "update .clang-format"
89ea20e 
This reverts commit e9ddf57.
cz4rs added a commit that referenced this issue Oct 20, 2022
@cz4rs
#1830: lb: extract helper methods in TemperedLB
c084292 
- extract helper methods and add overloads for TemperedWMin
- remove redundant code
- remove unused member variable
cz4rs added a commit that referenced this issue Oct 20, 2022
@cz4rs
#1830: TemperedWMin: allow all nodes to be potential recipients of work
faa8990
cz4rs added a commit that referenced this issue Oct 20, 2022
@cz4rs
#1830: remove duplicated struct
231eaf7
cz4rs added a commit that referenced this issue Oct 20, 2022
@cz4rs
#1830: TemperedWMin: exclude current node from potential recipients
db8b936
cz4rs added a commit that referenced this issue Oct 20, 2022
@cz4rs
#1830: TemperedWMin: provide canMigrate override
837ae83
cz4rs added a commit that referenced this issue Oct 20, 2022
@cz4rs
#1830: TemperedWMin: pretend all nodes are underloaded
5cddd35
cz4rs added a commit that referenced this issue Oct 20, 2022
@cz4rs
#1830: lb: make getModeledValue const
e2777a3
cz4rs added a commit that referenced this issue Dec 21, 2022
@cz4rs
#1830: lb: extract helper methods in TemperedLB
7fc9b42 
- extract helper methods and add overloads for TemperedWMin
- remove redundant code
- remove unused member variable
cz4rs added a commit that referenced this issue Dec 21, 2022
@cz4rs
#1830: TemperedWMin: allow all nodes to be potential recipients of work
1194a01
cz4rs added a commit that referenced this issue Dec 21, 2022
@cz4rs
#1830: TemperedWMin: exclude current node from potential recipients
8fda094
cz4rs added a commit that referenced this issue Dec 21, 2022
@cz4rs
#1830: TemperedWMin: provide canMigrate override
f455e23
cz4rs added a commit that referenced this issue Dec 21, 2022
@cz4rs
#1830: TemperedWMin: pretend all nodes are underloaded
ccc3728
cz4rs added a commit that referenced this issue Dec 21, 2022
@cz4rs
#1830: lb: make getModeledValue const
23608d2
cz4rs added a commit that referenced this issue Feb 28, 2023
@cz4rs
#1830: lb: extract helper methods in TemperedLB
1002ab1 
- extract helper methods and add overloads for TemperedWMin
- remove redundant code
- remove unused member variable
cz4rs added a commit that referenced this issue Feb 28, 2023
@cz4rs
#1830: TemperedWMin: allow all nodes to be potential recipients of work
246f160
cz4rs added a commit that referenced this issue Feb 28, 2023
@cz4rs
#1830: TemperedWMin: exclude current node from potential recipients
dee4128
cz4rs added a commit that referenced this issue Feb 28, 2023
@cz4rs
#1830: TemperedWMin: provide canMigrate override
334b399
cz4rs added a commit that referenced this issue Feb 28, 2023
@cz4rs
#1830: TemperedWMin: pretend all nodes are underloaded
ecf1d46
cz4rs added a commit that referenced this issue Feb 28, 2023
@cz4rs
#1830: lb: make getModeledValue const
cf8804f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cz4rs cz4rs

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1830: Remove concept of under/overloaded from TemperedWMin DARMA-tasking/vt
2 participants
@cz4rs @nlslatt