Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1382: collect histogram of process loads #1873

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

stmcgovern
Copy link
Contributor

Closes #1382.

@github-actions
Copy link

github-actions bot commented Jul 19, 2022

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for fd748ca

FAILED: src/CMakeFiles/vt.dir/Unity/unity_10_cxx.cxx.o 
/usr/bin/ccache /usr/lib/ccache/g++ -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DVT_NO_COLOR_ENABLED -I/vt/lib/CLI -Irelease -I/vt/src -I/vt/lib/json/include -I/vt/lib/brotli/c/include -I/vt/lib/libfort/lib -isystem /vt/lib/fmt/include -isystem /vt/lib/EngFormat-Cpp/include -isystem /build/checkpoint/install/include -isystem /build/detector/install/include -O3 -DNDEBUG -Wall -pedantic -Wshadow -Wno-unknown-pragmas -Wsign-compare -ftemplate-backtrace-limit=100 -Werror -fPIC -std=c++14 -MD -MT src/CMakeFiles/vt.dir/Unity/unity_10_cxx.cxx.o -MF src/CMakeFiles/vt.dir/Unity/unity_10_cxx.cxx.o.d -o src/CMakeFiles/vt.dir/Unity/unity_10_cxx.cxx.o -c src/CMakeFiles/vt.dir/Unity/unity_10_cxx.cxx
In file included from src/CMakeFiles/vt.dir/Unity/unity_10_cxx.cxx:9:
/vt/src/vt/vrt/collection/balance/lb_common.cc: In function 'nlohmann::vt::json vt::vrt::collection::lb::jsonifyPhaseStatistics(const StatisticMap&)':
/vt/src/vt/vrt/collection/balance/lb_common.cc:161:56: error: no match for 'operator=' (operand types are 'nlohmann::vt::basic_json<>::value_type' {aka 'nlohmann::vt::basic_json<>'} and 'const vt::util::adt::AlignedCharUnion<double, vt::util::adt::HistogramApprox<double, long int> >')
  161 |       this_stat[quant_name.get<std::string>()] = quant.second;
      |                                                        ^~~~~~
In file included from /vt/src/vt/vrt/collection/types/storage/store_elm.h:49,
                 from /vt/src/vt/vrt/collection/types/storage/storable.h:48,
                 from /vt/src/vt/vrt/collection/types/migratable.h:52,
                 from /vt/src/vt/vrt/collection/types/indexable.h:52,
                 from /vt/src/vt/vrt/collection/types/base.h:51,
                 from /vt/src/vt/vrt/collection/types/headers.h:55,
                 from /vt/src/vt/vrt/collection/messages/system_create.h:50,
                 from /vt/src/vt/vrt/collection/manager.h:51,
                 from /vt/src/vt/vrt/collection/manager.cc:49,
                 from src/CMakeFiles/vt.dir/Unity/unity_10_cxx.cxx:3:
/vt/lib/json/include/nlohmann/json.hpp:2174:17: note: candidate: 'nlohmann::vt::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>& nlohmann::vt::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::operator=(nlohmann::vt::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>) [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType = dou%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log


// static_assert(
// vt::messaging::is_byte_copyable_t<LoadData>::value,
// "Must be trivially copyable to avoid serialization."
// );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can just be deleted now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect histogram of process loads (modeled and raw) in LB data reduction
2 participants