#2286: Remove `gcc-8` support #2360

thearusable · 2024-09-30T14:12:54Z

github-actions · 2024-09-30T16:18:49Z

Pipelines results

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 6b623be (2024-11-14 16:15:04 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (clang-10, ubuntu, mpich)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich, verbose)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich, verbose)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for a505c09 (2024-11-22 17:07:04 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Testing - passed

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for a505c09 (2024-11-22 17:07:04 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for a505c09 (2024-11-22 17:07:04 UTC)

remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhi%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for a505c09 (2024-11-22 17:07:04 UTC)

Compilation - successful

Testing - passed

Build log

cz4rs · 2024-11-19T12:38:37Z

examples/lb_data/lb_data_file_example.json

@@ -23,7 +23,7 @@
        {
            "communications": [
                {
-                    "bytes": 152.0,
+                    "bytes": 160.0,


I assume this is a result of switching JSON validation from gcc-9 to clang-16.

README.md

cwschilly · 2024-11-21T14:03:59Z

docker-compose.yml

@@ -10,7 +10,7 @@
 # Variables:
 #   ARCH={amd64, arm64v8, ...}
 #   COMPILER_TYPE={gnu, clang, intel, nvidia}
-#   COMPILER={gcc-8, gcc-9, gcc-10,
+#   COMPILER={gcc-9, gcc-10,


Is gcc-13 now an option as well?

Yes, added some other missing variants too.

cz4rs · 2024-11-21T18:22:06Z

ci/docker/ubuntu-clang-cpp.dockerfile

-
-ARG BUILD_SHARED_LIBS
-ARG CMAKE_BUILD_TYPE
-ARG VT_ASAN_ENABLED
-ARG VT_DOXYGEN_ENABLED
-ARG VT_EXTENDED_TESTS_ENABLED
-ARG VT_FCONTEXT_ENABLED
-ARG VT_LB_ENABLED
-ARG VT_MIMALLOC_ENABLED
-ARG VT_NO_COLOR_ENABLED
-ARG VT_POOL_ENABLED
-ARG VT_PRODUCTION_BUILD_ENABLED
-ARG VT_TRACE_ENABLED
-ARG VT_TRACE_RUNTIME_ENABLED
-ARG VT_UBSAN_ENABLED
-ARG VT_WERROR_ENABLED
-ARG CMAKE_CXX_STANDARD
-ARG VT_DEBUG_VERBOSE
-ARG VT_CI_BUILD
-
-ENV BUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} \
-    CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \
-    VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
-    VT_DIAGNOSTICS_ENABLED=${VT_DIAGNOSTICS_ENABLED} \
-    VT_DIAGNOSTICS_RUNTIME_ENABLED=${VT_DIAGNOSTICS_RUNTIME_ENABLED} \
-    VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
-    VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \
-    VT_FCONTEXT_ENABLED=${VT_FCONTEXT_ENABLED} \
-    VT_LB_ENABLED=${VT_LB_ENABLED} \
-    VT_MIMALLOC_ENABLED=${VT_MIMALLOC_ENABLED} \
-    VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
-    VT_NO_COLOR_ENABLED=${VT_NO_COLOR_ENABLED} \
-    VT_POOL_ENABLED=${VT_POOL_ENABLED} \
-    VT_PRODUCTION_BUILD_ENABLED=${VT_PRODUCTION_BUILD_ENABLED} \
-    VT_TRACE_ENABLED=${VT_TRACE_ENABLED} \
-    VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
-    VT_UBSAN_ENABLED=${VT_UBSAN_ENABLED} \
-    VT_UNITY_BUILD_ENABLED=${VT_UNITY_BUILD_ENABLED} \
-    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
-    CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} \
-    VT_DEBUG_VERBOSE=${VT_DEBUG_VERBOSE} \
-    VT_CI_BUILD=${VT_CI_BUILD}
-


Drive-by change: those are not necessary to pass environment variables.

Use a build based on Ubuntu 24.04 to ensure recent versions of Python dependencies (python3-schema).

cwschilly

LGTM

thearusable self-assigned this Sep 30, 2024

thearusable force-pushed the 2286-remove-gcc-8-support branch from f09015f to a076496 Compare September 30, 2024 16:29

cz4rs marked this pull request as ready for review November 14, 2024 16:13

cz4rs force-pushed the 2286-remove-gcc-8-support branch 4 times, most recently from f2bcaea to 5d703e0 Compare November 18, 2024 12:03

cz4rs requested review from stmcgovern, lifflander, nmm0, JacobDomagala, nlslatt and cwschilly November 18, 2024 17:34

cz4rs reviewed Nov 19, 2024

View reviewed changes

cwschilly reviewed Nov 21, 2024

View reviewed changes

cz4rs reviewed Nov 21, 2024

View reviewed changes

cz4rs requested a review from cwschilly November 21, 2024 20:37

thearusable and others added 12 commits November 22, 2024 18:06

#2286: Remove gcc-8 references

4723d88

#2286: Remove std::filesystem workaround for gcc-8

4a493bd

#2286: Replace old gcc-8 address sanitizer CI with gcc-13

ac79d83

#2286: Remove workaround in code for gcc-8

3389b78

#2286: Remove warnings during perf tests compilation

fe764e0

#2286: Update ubuntu version for new CI to 24.04

82c439f

#2268: Fix installation of python packages on newer versions of ubuntu

b05fd41

#2268: Update gcc-8 references

5ed639e

#2268: Move gcc-13 pipeline definition to be in order

8492ad9

#2268: ignore invalid maybe-uninitialized warning

331b9b0

#2268: move JSON validation to clang-16 build

06373bf

Use a build based on Ubuntu 24.04 to ensure recent versions of Python dependencies (python3-schema).

#2268: remove gcc-8 badge from README

9ef1c4e

cz4rs added 4 commits November 22, 2024 18:07

#2268: add missing dependencies to clang dockerfile

ccef3b6

#2268: update json reference file

c665e10

#2268: remove redundant code from dockerfiles

633a461

#2268: add gcc-13 badge to README.md

a505c09

cz4rs force-pushed the 2286-remove-gcc-8-support branch from b42a1fa to a505c09 Compare November 22, 2024 17:07

cwschilly approved these changes Nov 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2286: Remove `gcc-8` support #2360

#2286: Remove `gcc-8` support #2360

thearusable commented Sep 30, 2024

github-actions bot commented Sep 30, 2024 •

edited

Loading

cz4rs Nov 19, 2024

cwschilly Nov 21, 2024

cz4rs Nov 21, 2024

cz4rs Nov 21, 2024

cwschilly left a comment

#2286: Remove gcc-8 support #2360

Are you sure you want to change the base?

#2286: Remove gcc-8 support #2360

Conversation

thearusable commented Sep 30, 2024

github-actions bot commented Sep 30, 2024 • edited Loading

Pipelines results

cz4rs Nov 19, 2024

Choose a reason for hiding this comment

cwschilly Nov 21, 2024

Choose a reason for hiding this comment

cz4rs Nov 21, 2024

Choose a reason for hiding this comment

cz4rs Nov 21, 2024

Choose a reason for hiding this comment

cwschilly left a comment

Choose a reason for hiding this comment

#2286: Remove `gcc-8` support #2360

#2286: Remove `gcc-8` support #2360

github-actions bot commented Sep 30, 2024 •

edited

Loading