Update local authorities data #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-tsh-review-219.test.teacherservices.cloud/ |
slawosz
force-pushed
the
2165-update-local-authorities-data
branch
from
9698d2b to
37226d1
Compare
jebw
approved these changes
Nov 13, 2024
README.md
Outdated
Comment on lines
28
to
40
| ```ruby | ||
| file = Rails.root.join("db/data/authorities.json").freeze | ||
|
|
||
| size = 80 | ||
| 5.times do |i| | ||
| data = JSON(File.read(file)) | ||
| data["features"] = data["features"][(size*i)...(size*(i+1))] | ||
|
|
||
| filename = Rails.root.join("db/data/authorities_#{i+1}.json") | ||
| File.open(filename, 'w') { |file| file.write(data.to_json) } | ||
| end | ||
| ``` |
There was a problem hiding this comment.
This can be a rake task the developer can just run locally?
slawosz
force-pushed
the
2165-update-local-authorities-data
branch
from
37226d1 to
2b2c36f
Compare
slawosz
force-pushed
the
2165-update-local-authorities-data
branch
from
2b2c36f to
e739112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a size of the
LocalAuthoritydata file, I had to split it to few files to avoid usingLarge File Storage.