Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2158] Replace terrafile #220

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[2158] Replace terrafile #220

merged 3 commits into from
Dec 5, 2024

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Dec 4, 2024

Context

Ticket: https://trello.com/c/5jCq2a3p

terrafile is no longer maintained

Changes proposed in this pull request

  • Replace terrafile with a simple git command
  • Update staging and sandbox domains
  • Fix aks-console and aks-ssh commands

How to review

  • Check new domains in README
  • make staging terraform-plan
  • make domains-infra-plan
  • make staging domains-plan
  • make staging aks-ssh
  • make staging aks-console

@saliceti
Replace terrafile
6b96b4d 
terrafile is not maintained anymore
@saliceti
Finalise staging and sandbox DNS
6d72231 
- Update the domain name
- Remove the "development" configuration as it was never used
@saliceti
Fix aks-console and aks-ssh commands
2298efd
@saliceti saliceti added the devops label Dec 4, 2024
@saliceti
Copy link
Member Author

saliceti commented Dec 4, 2024

Replace terrafile

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Review app deployed to https://cpd-tsh-review-220.test.teacherservices.cloud/

neillturner
neillturner approved these changes Dec 5, 2024
View reviewed changes
Copy link

@neillturner neillturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested all make commands successfully.
reviewed code changes for correctness

@saliceti saliceti added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit c2994f1 Dec 5, 2024
9 checks passed
@saliceti saliceti deleted the 2158-replace-terrafile branch December 5, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neillturner neillturner neillturner approved these changes

Assignees
No one assigned
Labels
devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saliceti @neillturner