Various improvements #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoerup
changed the title
Added the following methods:
char isSMS(typeSMS type = ALL);
bool getInfGPS();
Corrections on:
bool sendUSSDSynchronous(char *ussdCommand, char *resultcode, char *response);
Add some F() functions and commented the command "AT+CGNSTST=1" at attachGPS() function as suggested by @hoerup
|
@cnlg @Arduinolibrary Please review this PR |
pull caladeira's changes
|
Nice work with those commits, pity that PR is not merged yet. :( |
|
Thank you very much for the library!
|
|
I apologize for not reviewing and merging your branch earlier, which has resulted in some conflicts that cannot be merged directly. Currently, we have two options: either I can manually add the changes you made to the main branch by comparing the differences, or you can rebase your changes on top of the latest main branch and resubmit the merge request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.