Merge remote-tracking branch 'origin/beta' into beta #74
DIDIRUS4Annotations
3 errors and 19 warnings
|
test-tauri (ubuntu-22.04)
Command failed with exit code 1: tauri build
|
|
test-tauri (ubuntu-20.04)
Command failed with exit code 1: tauri build
|
|
test-tauri (windows-latest)
Command failed with exit code 1: tauri build
|
|
test-tauri (ubuntu-22.04)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
test-tauri (ubuntu-22.04):
theseus_gui/src/components/ui/AccountsCard.vue#L116
Attribute "v-model" should go before "type"
|
|
test-tauri (ubuntu-22.04):
theseus_gui/src/pages/Settings.vue#L588
Attribute "id" should go before "class"
|
|
test-tauri (ubuntu-22.04):
theseus_gui/src/pages/Settings.vue#L588
Attribute "id" should go before "class"
|
|
test-tauri (ubuntu-22.04):
theseus_gui/src/components/ui/AccountsCard.vue#L116
Attribute "v-model" should go before "type"
|
|
test-tauri (ubuntu-20.04)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
test-tauri (ubuntu-20.04):
theseus_gui/src/components/ui/AccountsCard.vue#L116
Attribute "v-model" should go before "type"
|
|
test-tauri (ubuntu-20.04):
theseus_gui/src/pages/Settings.vue#L588
Attribute "id" should go before "class"
|
|
test-tauri (ubuntu-20.04):
theseus_gui/src/pages/Settings.vue#L588
Attribute "id" should go before "class"
|
|
test-tauri (ubuntu-20.04):
theseus_gui/src/components/ui/AccountsCard.vue#L116
Attribute "v-model" should go before "type"
|
|
test-tauri (windows-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
test-tauri (windows-latest):
theseus_gui/src/components/ui/AccountsCard.vue#L116
Attribute "v-model" should go before "type"
|
|
test-tauri (windows-latest):
theseus_gui/src/pages/Settings.vue#L588
Attribute "id" should go before "class"
|
|
test-tauri (windows-latest):
theseus_gui/src/pages/Settings.vue#L588
Attribute "id" should go before "class"
|
|
test-tauri (windows-latest):
theseus_gui/src/components/ui/AccountsCard.vue#L116
Attribute "v-model" should go before "type"
|
|
useless use of `format!`:
theseus/src/state/mod.rs#L196
warning: useless use of `format!`
--> theseus/src/state/mod.rs:196:53
|
196 | let _ = discord_rpc.force_set_activity(&format!("{}", selected_phrase), true).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `selected_phrase.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
|
|
useless use of `format!`:
theseus/src/state/discord.rs#L272
warning: useless use of `format!`
--> theseus/src/state/discord.rs:272:32
|
272 | self.set_activity(&format!("{}", selected_phrase), reconnect_if_fail).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `selected_phrase.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
theseus/src/state/discord.rs#L166
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> theseus/src/state/discord.rs:166:29
|
166 | .small_text(&build_download)
| ^^^^^^^^^^^^^^^ help: change this to: `build_download`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
braces around Deserialize is unnecessary:
theseus/src/api/hydra/complete.rs#L3
warning: braces around Deserialize is unnecessary
--> theseus/src/api/hydra/complete.rs:3:1
|
3 | use serde::{Deserialize};
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> theseus/src/lib.rs:7:9
|
7 | #![warn(unused_import_braces)]
| ^^^^^^^^^^^^^^^^^^^^
|