Skip to content

[beta] Development Build v21 • Beta. Fix auto start installer?

Sign in for the full log view
GitHub Actions / clippy succeeded Jan 16, 2024 in 0s

clippy

8 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 8
Note 0
Help 0

Versions

  • rustc 1.75.0 (82e1608df 2023-12-21)
  • cargo 1.75.0 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check warning on line 196 in theseus/src/state/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `format!`

warning: useless use of `format!`
   --> theseus/src/state/mod.rs:196:53
    |
196 |             let _ = discord_rpc.force_set_activity(&format!("{}", selected_phrase), true).await;
    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `selected_phrase.to_string()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

Check warning on line 272 in theseus/src/state/discord.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `format!`

warning: useless use of `format!`
   --> theseus/src/state/discord.rs:272:32
    |
272 |             self.set_activity(&format!("{}", selected_phrase), reconnect_if_fail).await?;
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `selected_phrase.to_string()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
    = note: `#[warn(clippy::useless_format)]` on by default

Check warning on line 166 in theseus/src/state/discord.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> theseus/src/state/discord.rs:166:29
    |
166 |                 .small_text(&build_download)
    |                             ^^^^^^^^^^^^^^^ help: change this to: `build_download`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 26 in theseus/src/api/download.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary parentheses around `if` condition

warning: unnecessary parentheses around `if` condition
  --> theseus/src/api/download.rs:26:19
   |
26 |         } else if (open_cmd == "open") {
   |                   ^                  ^
   |
help: remove these parentheses
   |
26 -         } else if (open_cmd == "open") {
26 +         } else if open_cmd == "open" {
   |

Check warning on line 18 in theseus/src/api/download.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary parentheses around `if` condition

warning: unnecessary parentheses around `if` condition
  --> theseus/src/api/download.rs:18:12
   |
18 |         if (open_cmd == "start") {
   |            ^                   ^
   |
help: remove these parentheses
   |
18 -         if (open_cmd == "start") {
18 +         if open_cmd == "start" {
   |

Check warning on line 16 in theseus/src/api/download.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary parentheses around `if` condition

warning: unnecessary parentheses around `if` condition
  --> theseus/src/api/download.rs:16:8
   |
16 |     if (auto_update_supported) {
   |        ^                     ^
   |
   = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
   |
16 -     if (auto_update_supported) {
16 +     if auto_update_supported {
   |

Check warning on line 2 in theseus/src/api/download.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `std::ptr::null`

warning: unused import: `std::ptr::null`
 --> theseus/src/api/download.rs:2:5
  |
2 | use std::ptr::null;
  |     ^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 3 in theseus/src/api/hydra/complete.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

braces around Deserialize is unnecessary

warning: braces around Deserialize is unnecessary
 --> theseus/src/api/hydra/complete.rs:3:1
  |
3 | use serde::{Deserialize};
  | ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
note: the lint level is defined here
 --> theseus/src/lib.rs:7:9
  |
7 | #![warn(unused_import_braces)]
  |         ^^^^^^^^^^^^^^^^^^^^