Merge commit '6699b4cb33a6a10b7a7c282360cea6b23b719b55' into beta #84
clippy
5 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 5 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.77.1 (7cf61ebde 2024-03-27)
- cargo 1.77.1 (e52e36006 2024-03-26)
- clippy 0.1.77 (7cf61eb 2024-03-27)
Annotations
Check warning on line 196 in theseus/src/state/mod.rs
github-actions / clippy
useless use of `format!`
warning: useless use of `format!`
--> theseus/src/state/mod.rs:196:53
|
196 | let _ = discord_rpc.force_set_activity(&format!("{}", selected_phrase), true).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `selected_phrase.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
Check warning on line 272 in theseus/src/state/discord.rs
github-actions / clippy
useless use of `format!`
warning: useless use of `format!`
--> theseus/src/state/discord.rs:272:32
|
272 | self.set_activity(&format!("{}", selected_phrase), reconnect_if_fail).await?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `selected_phrase.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
Check warning on line 166 in theseus/src/state/discord.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> theseus/src/state/discord.rs:166:29
|
166 | .small_text(&build_download)
| ^^^^^^^^^^^^^^^ help: change this to: `build_download`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 34 in theseus/src/event/mod.rs
github-actions / clippy
you are explicitly cloning with `.map()`
warning: you are explicitly cloning with `.map()`
--> theseus/src/event/mod.rs:26:9
|
26 | / EVENT_STATE
27 | | .get_or_try_init(|| async {
28 | | Ok(Arc::new(Self {
29 | | app,
... |
33 | | .await
34 | | .map(Arc::clone)
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
help: consider calling the dedicated `cloned` method
|
26 ~ EVENT_STATE
27 + .get_or_try_init(|| async {
28 + Ok(Arc::new(Self {
29 + app,
30 + loading_bars: RwLock::new(HashMap::new()),
31 + }))
32 + })
33 + .await.cloned()
|
Check warning on line 3 in theseus/src/api/hydra/complete.rs
github-actions / clippy
braces around Deserialize is unnecessary
warning: braces around Deserialize is unnecessary
--> theseus/src/api/hydra/complete.rs:3:1
|
3 | use serde::{Deserialize};
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> theseus/src/lib.rs:7:9
|
7 | #![warn(unused_import_braces)]
| ^^^^^^^^^^^^^^^^^^^^