-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve whitepaper code and small fixes #103
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
ffac7d6
to
19d4452
Compare
Why is the automatic deployment not working? |
@florianhartung I think I know what the issue is. Your PR would work with acrostiche 0.4.0, but not with 0.4.1 . Nix is a "reproducible" built system so it builds everything from scratch (+ cache), but web requests are not reproducible, so internet is disabled in the build process. My hypothesis is that the package 0.4.0 is indexed by <> and build in-place, but 0.4.1 is not. As a fail-safe it tries to download it from the internet but since Nix is Nix, it blocks web requests and thus it fails. This is most likely an issue with the nix script, a nix dependency versioning issue, or the nix packages itself that handles typst packages. @wucke13 would have a better intuition in this sense. The short answer: downgrade to acrostiche 0.4.0 (like it was originally). I will try to look into it, but not guarantees to make it work. |
Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
32880c7
to
08bf5fa
Compare
|
@george-cosma Yes you were correct, the flake input nix flake lock --update-input typst-packages |
Pull Request Overview
This pull request changes the structure of out whitepaper Typst project.
I have used Typst myself and this pull request contains some opinionated improvements and fixes for our project.
Formatting
cargo fmt
cargo check
cargo build
cargo doc
nix fmt