Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve whitepaper code and small fixes #103

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

florianhartung
Copy link
Collaborator

Pull Request Overview

This pull request changes the structure of out whitepaper Typst project.
I have used Typst myself and this pull request contains some opinionated improvements and fixes for our project.

Formatting

  • Ran cargo fmt
  • Ran cargo check
  • Ran cargo build
  • Ran cargo doc
  • Ran nix fmt

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/core/reader/types/data.rs 15.95% <ø> (ø)

@florianhartung florianhartung force-pushed the refactor/whitepaper branch 2 times, most recently from ffac7d6 to 19d4452 Compare December 9, 2024 14:50
@florianhartung florianhartung added documentation Improvements or additions to documentation priority-low and removed core priority-high labels Dec 9, 2024
@florianhartung
Copy link
Collaborator Author

Why is the automatic deployment not working?
For me https://packages.typst.org/preview/acrostiche-0.4.1.tar.gz works just fine.

@george-cosma
Copy link
Collaborator

@florianhartung I think I know what the issue is. Your PR would work with acrostiche 0.4.0, but not with 0.4.1 . Nix is a "reproducible" built system so it builds everything from scratch (+ cache), but web requests are not reproducible, so internet is disabled in the build process.

My hypothesis is that the package 0.4.0 is indexed by <> and build in-place, but 0.4.1 is not. As a fail-safe it tries to download it from the internet but since Nix is Nix, it blocks web requests and thus it fails.

This is most likely an issue with the nix script, a nix dependency versioning issue, or the nix packages itself that handles typst packages. @wucke13 would have a better intuition in this sense.

The short answer: downgrade to acrostiche 0.4.0 (like it was originally). I will try to look into it, but not guarantees to make it work.

Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://DLR-FT.github.io/wasm-interpreter/whitepaper/pr-preview/pr-103/
on branch gh-pages at 2024-12-10 17:02 UTC

@florianhartung
Copy link
Collaborator Author

@george-cosma Yes you were correct, the flake input typst-packages was still locked to an old version where acrostiche 0.4.1 didn't exist yet. I fixed it by running:

nix flake lock --update-input typst-packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority-low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants