Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import example implementation #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

nerodesu017
Copy link
Collaborator

Pull Request Overview

This pull request adds basic support for imports.

Testing Strategy

This pull request was tested using the provided test cases.

TODO or Help Wanted

It is to be discussed if this is a way through which we could implement the imports and keep the code still executing our tests (a.k.a. not break function calling).

Formatting

  • Ran cargo fmt
  • Ran cargo check
  • Ran cargo build
  • Ran cargo doc
  • Ran nix fmt

Github Issue

N/A

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 92.76316% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/execution/mod.rs 93.49% 7 Missing and 1 partial ⚠️
src/validation/mod.rs 87.50% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/execution/interpreter_loop.rs 93.53% <100.00%> (ø)
src/execution/store.rs 53.33% <ø> (ø)
src/validation/mod.rs 63.82% <87.50%> (+6.10%) ⬆️
src/execution/mod.rs 91.37% <93.49%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

@florianhartung
Copy link
Collaborator

i think this is related to #27

@wucke13
Copy link
Collaborator

wucke13 commented Sep 4, 2024

Maybe it is nicer to have all functions live in the same table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants