-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linker API Changes #88
Conversation
I recommend looking at the first commit and the last. The one in the middle only changes the tests. |
95328ef
to
4820a3b
Compare
Codecov ReportAttention: Patch coverage is
|
fda3926
to
ad23b4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
47111bf
to
8c3b877
Compare
Signed-off-by: George Cosma <[email protected]>
Signed-off-by: George Cosma <[email protected]>
8c3b877
to
7411d43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Overview
This pull request changes the RuntimeInstance API to be compatible with the #87 linker proposal. The PR follows the proposal highlighted in issue #83, more precisely this comment. This was made to avoid the multitude of functions that would be create when introducing the idea of "modules" and "module_index"
Formatting
cargo fmt
cargo check
cargo build
cargo doc
nix fmt
Github Issue
This pull request helps close #83