-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.8 and add python 3.12 support #2041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -151,7 +150,7 @@ def setup(app): | |||
|
|||
# -- Options for LaTeX output ------------------------------------------------ | |||
|
|||
latex_elements: Dict[str, str] = { | |||
latex_elements: dict[str, str] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? (Out of curiosity)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's python 3.9 syntax, from typing import Dict
is deprecated, you can use dict[]
directly now (and with python 3.10, there is the |
syntax for union.
I used ruff check --select UP --fix --unsafe-fixes
to automatically upgrade everything.
There is some failure for python 3.12, I will have a look
Note: with python 3.8, dict[]
would raise an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, thanks!
Description
Upgraded to PyTorch >=2.3 (numpy 2.0 support), upgraded to python 3.9 syntax.
Added python 3.12 to CI.
closes #1960
Motivation and Context
Types of changes
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line