Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CPACS to version 3.4 #1027

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Update CPACS to version 3.4 #1027

merged 2 commits into from
Oct 16, 2024

Conversation

svengoldberg
Copy link
Contributor

Fixes #1013

This PR updates the CPACS version to 3.4

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.18%. Comparing base (f6f1e4c) to head (eb6f4ef).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/CCPACSPoint.cpp 0.00% 3 Missing ⚠️
src/geometry/CCPACSTransformation.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   70.19%   70.18%   -0.02%     
==========================================
  Files         301      301              
  Lines       24429    24433       +4     
==========================================
  Hits        17148    17148              
- Misses       7281     7285       +4     
Flag Coverage Δ
unittests 70.18% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/geometry/CCPACSTransformation.cpp 82.75% <0.00%> (-1.46%) ⬇️
src/CCPACSPoint.cpp 73.58% <0.00%> (-2.89%) ⬇️

src/CCPACSPoint.h Outdated Show resolved Hide resolved
@joergbrech joergbrech merged commit e4b77e9 into master Oct 16, 2024
15 of 17 checks passed
@joergbrech joergbrech deleted the 1013_update_cpacs_3_4 branch October 16, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CPACS schema to 3.4
2 participants