Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce tolerance when creating cells via contourCoordinate in chordwise direction #1034

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

svengoldberg
Copy link
Contributor

@svengoldberg svengoldberg commented Nov 13, 2024

This fix is related to PR #1026 and the belonging issue #933.
In the named PR, the tolerance was only reduced in spanwise direction. This PR also adds the reduction for the chordwise direction to fix cell overlap in the other direction.

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.
  • Changes were documented in tigl/ChangeLog.md

…ordwise direction

In PR #1026, the cell overlap issue was solved in spanwise direction. However, the same might appear in chordwise direction, as well. So, this tolerance is also reduced.
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (10a7fcf) to head (dfa06d8).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1034   +/-   ##
=======================================
  Coverage   69.47%   69.47%           
=======================================
  Files         301      301           
  Lines       26889    26889           
=======================================
  Hits        18681    18681           
  Misses       8208     8208           
Flag Coverage Δ
unittests 69.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/wing/CCPACSWingCell.cpp 77.98% <100.00%> (ø)

@joergbrech joergbrech merged commit b9c75f1 into master Nov 13, 2024
17 checks passed
@joergbrech joergbrech deleted the issue_cell_overlap_chordwise branch November 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants