Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Checklist in PR template #1038

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Update Checklist in PR template #1038

merged 2 commits into from
Nov 29, 2024

Conversation

joergbrech
Copy link
Contributor

@joergbrech joergbrech commented Nov 29, 2024

I updated the checklist in the PR template

Description

We want to be more disciplined in actually checking the template. In many PRs, the tasks in the checklist are meaningless, which means in many PRs they are never checked and simply ignored. I think this causes us as contributors and reviewers to be a bit lax. I updated it so that both contributors and reviewers must add a check in each row.

Checklist:

  • A test for the new functionality was added. Does not apply
  • All tests run without failure. Does not apply
  • The new code complies with the TiGL style guide. Does not apply
  • New classes have been added to the Python interface. Does not apply
  • API changes were documented properly in tigl.h. Does not apply
  • Changes were documented in tigl/ChangeLog.md Does not apply

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (8c80c8b) to head (2aa4991).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1038   +/-   ##
=======================================
  Coverage   69.47%   69.47%           
=======================================
  Files         301      301           
  Lines       26889    26889           
=======================================
  Hits        18681    18681           
  Misses       8208     8208           
Flag Coverage Δ
unittests 69.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@svengoldberg svengoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea! Out of my own experience, I think the old version might need an update 👍

.github/pull_request_template.md Outdated Show resolved Hide resolved
Copy link
Contributor

@svengoldberg svengoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, everything looks fine 👍

@joergbrech joergbrech merged commit c5ccbb2 into master Nov 29, 2024
17 checks passed
@joergbrech joergbrech deleted the update-pr-template branch November 29, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants