CPACS-Creator: Add error handling when a section should be added in (or next to) a segment containing guide curves #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CPACS creator currently allows adding sections in segments (or at their boundaries) when they contain guide curves. However this leads to crashes or undefined behaviour. As it might be hard to discuss reasonable behaviour or predict what the user wants in complex examples, we do not allow this right now. (At least partly) fixes issue #626
Fix Python wrapper returns SwigPyObject instead of CPACSWalls (Issue #1012)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cpacs_creator_dev_merge #1039 +/- ##
===========================================================
+ Coverage 69.47% 71.40% +1.92%
===========================================================
Files 301 312 +11
Lines 26889 28978 +2089
===========================================================
+ Hits 18681 20691 +2010
- Misses 8208 8287 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joergbrech
requested changes
Nov 29, 2024
…n touches GC segments
joergbrech
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the CPACS-Creator a section can be added within or next to a segment that contains guide curves (issue #626).
Right now, this results in an error occuring elsewhere or undefined behaviour. Therefore, for the moment it should not be allowed for a user to do this.
From a CPACS perspective it seems reasonable: The guide curves are generally defined after all sections are created as the guide curves depent on them.
Fixes #626
If users seek for this feature, we can think about a way to handle this. But it should not be an urgent task.
Checklist: