-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce fast and deterministic RNG #615
Introduce fast and deterministic RNG #615
Conversation
6578a55
to
8a021b6
Compare
8a021b6
to
08a9a1c
Compare
08a9a1c
to
3f8d5eb
Compare
3f8d5eb
to
4bf7fbe
Compare
4bf7fbe
to
b535ac1
Compare
b535ac1
to
9af9c80
Compare
I am curious. Doesn't it still generate the same random number sequence? |
After searching, I realize that "consistent random number sequence" means the RNG always produces the same random number sequence every time the test program is run. Is that what we are going to discuss about? |
Yes that is exactly what I mentioned. So do we need to have a consistent random number sequence or maybe not? |
For the purpose of CI pipeline, we shall stick to deterministic random number generation. |
Got it. |
I agree. Just close the original issue with a comment mentioning about sticking to deterministic random number generation of CI pipelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refine the subject per discussions.
issue was closed |
As the |
The proposed RNG still makes sense for cross-platform consideration. In particular, this project supports GCC, Clang, and MSVC in combination with Linux, macOS, and Windows. Therefore, a fast and deterministic RNG can minimize potential issues while performing tests. @Cuda-Chen, please refine the commit messages. |
Use SplitMix64 for fast and deterministic RNG for cross compiler/platform support.
9af9c80
to
4142eee
Compare
Use SplitMix64 for fast and deterministic RNG for cross compiler/platform support.