Add option to set a different set of languages allowed to submit per … #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
force-pushed
the
langcontest
branch
5 times, most recently
from
0270585
to
4a79f9d
Compare
nickygerritsen
approved these changes
Nov 24, 2024
…contest. If empty, falls back to the global definition. This is part of DOMjudge#2521.
meisterT
force-pushed
the
langcontest
branch
from
4a79f9d
to
cfa998f
Compare
eldering
reviewed
Nov 24, 2024
| @@ -453,9 +453,10 @@ public function submitSolution( | |||
| throw new BadRequestHttpException('Submissions for contest (temporarily) disabled'); | |||
| } | |||
|
|
|||
| if (!$language->getAllowSubmit()) { | |||
| $allowedLanguages = $this->dj->getAllowedLanguagesForContest($contest); | |||
| if (!in_array($language, $allowedLanguages, true)) { | |||
There was a problem hiding this comment.
Nitpick, maybe consider:
Suggested change
| if (!in_array($language, $allowedLanguages, true)) { | |
| if (!in_array($language, $allowedLanguages, strict: true)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…contest.
If empty, falls back to the global definition.
This is part of #2521.