-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added blogs #55
base: master
Are you sure you want to change the base?
Added blogs #55
Conversation
Hi Aditya, I did not look at the code properly, but on a higher level seems good work to me. Anyways, for now, not a problem at all, I will take care of that while I will merge the functionality. Other than that, I will go through it nicely over the weekend and merge it. |
Yes sorry for that, I deleted the project after the commit so no problem there but from next time I will not include it. |
I see good work done here on adding the blog section! I am not well verse with the codebade, i did go thru the changes done now, looks fine :) @raghavddps2 @Aditya9111 was there any discussion you guys had on using some template based rendering things like jekyll, i think it would have reduced our coding work on could reduce mem foot print on mongo if we are paying. |
Hey Aditya, You need to raise this PR on this repo: Latest Website Code and not on the current repository. I am sorry, During the previous comment, I didn't look at the repo itself. The repository link given above is the one that we for the Continuous deployment on Heroku. Please raise a pull request there. There won't be a lot of code changes as the code is pretty similar. But we did create that for some reason, so request you to do it there. That code is extremely fragile and I don't want to take the risk of merging your functionality from here to there. |
Yesss, Jekyll is a great option. We could have gone ahead with that. But as this functionality was very similar to event report(feature) code we already had, so went ahead with that. Let's use jekyll sometime in the future. |
ok, but the link is not working.Pls check |
P.S: I do understand that the heading for the repo you pushed the PR was misleading saying "New website code", However, I have fixed that now. Really sorry for the inconvenience. |
Sure, Given you access. Please check. It is a private repository. |
nice ! share the blog link |
|
Added Blog
templates added:
blogs.html
add_blog_post.html
edit_blog_post.html
blog_post.html
routes added:
/blogs
/blog_post/string:post_id
/add_blog_post
/edit_blog_post/string:post_id
/delete_blog/string:id