Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pylint for model and visualizationGenerator and changed other n… #32

Merged
merged 7 commits into from
Mar 8, 2024
Merged

Added pylint for model and visualizationGenerator and changed other n… #32

merged 7 commits into from
Mar 8, 2024

Conversation

abhinavdv
Copy link
Contributor

…ecessary files

Background

  1. Updated util files: model.py and VisualizationGenerator.py to satisfy 10/10 linting
  2. Modified other files to work with changes made due to changes for satisfying pylint

@abhinavdv abhinavdv requested a review from raaguln March 8, 2024 21:37
@abhinavdv
Copy link
Contributor Author

Also pushed some virtual environment changes

raaguln
raaguln approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@raaguln raaguln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated version dependency in github actions for the issue with scikit-learn. Your commits look good, merging them in.

@raaguln raaguln merged commit 89afb08 into main Mar 8, 2024
6 checks passed
@raaguln raaguln deleted the abhinavdv/pylint-check-for-utils branch March 8, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raaguln raaguln raaguln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhinavdv @raaguln