Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swarali desai/bug fixes #40

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Swarali desai/bug fixes #40

merged 6 commits into from
Mar 13, 2024

Conversation

swarali-desai
Copy link
Contributor

This PR has the following changes:

  1. Made return for character as lower
  2. remove additional chars in charcter name which was breaking in UI
  3. Corrected the data csv path

raaguln
raaguln approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@raaguln raaguln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an extra commit to update the test cases that visualizaiton_generator were using which was in your old input format. Looks good to me, merging it in!

@raaguln raaguln merged commit cc8b4dc into main Mar 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raaguln raaguln raaguln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swarali-desai @raaguln @abhinavdv