Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect RV300 and VC4 hardware and disable slow half float vertex on them #1347

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Detect RV300 and VC4 hardware and disable slow half float vertex on them #1347

merged 2 commits into from
Oct 12, 2024

Conversation

illwieckz
Copy link
Member

@illwieckz illwieckz mentioned this pull request Oct 11, 2024
Closed
@illwieckz illwieckz force-pushed the illwieckz/float-vertex branch from 7ab7dd7 to 9da022d Compare October 11, 2024 19:05
@illwieckz illwieckz changed the title Detect RV300 cards and disable slow half float vertex on them Detect RV300 and VC4 hardware and disable slow half float vertex on them Oct 11, 2024
@illwieckz
Copy link
Member Author

I also added VC4 detection, it's twice faster with float vertex on it.

Before (25fps):

unvanquished_2024-10-11_183704_000

After (55fps):

unvanquished_2024-10-11_184004_000

slipher
slipher reviewed Oct 11, 2024
View reviewed changes
src/engine/sys/sdl_glimp.cpp Outdated Show resolved Hide resolved
src/engine/sys/sdl_glimp.cpp Outdated

if ( !halfFloatVertexEnabled )
{
logger.Warn( "Missing half-float vertex, using float vertex instead." );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Notice for this one. We shouldn't use Warn so much unless there is a serious problem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to have a bolder log for such things, especially when it is reporting about making decisions, it makes it easier to catch them in logs. Though I agree Warn is maybe too much.

@illwieckz illwieckz force-pushed the illwieckz/float-vertex branch from 9da022d to d4a3c5c Compare October 12, 2024 00:35
@illwieckz
Copy link
Member Author

I addressed the various comments.

@slipher
Copy link
Member

slipher commented Oct 12, 2024

I also added VC4 detection, it's twice faster with float vertex on it.

Forgot to push something? I don't see any new stuff.

@illwieckz illwieckz force-pushed the illwieckz/float-vertex branch from d4a3c5c to 3cbd0a7 Compare October 12, 2024 02:46
@illwieckz
Copy link
Member Author

I also added VC4 detection, it's twice faster with float vertex on it.

Forgot to push something? I don't see any new stuff.

Indeed, now fixed.

@slipher
Copy link
Member

slipher commented Oct 12, 2024

LGTM

@illwieckz illwieckz merged commit 6d5bbba into for-0.55.0/sync Oct 12, 2024
9 checks passed
@illwieckz illwieckz deleted the illwieckz/float-vertex branch October 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VReaperV VReaperV VReaperV left review comments

@slipher slipher slipher left review comments

Assignees
No one assigned
Labels
A-Renderer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illwieckz @slipher @VReaperV