Bug fix + cvar migration for r_textureMode #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VReaperV
reviewed
Dec 24, 2024
Note: previously I was thinking that I would need a Modified latched cvar so there are a bunch of tests for that case. But we may end up not using it.
GL_TextureMode() does not interact with the bound texture unit. Also clear modified flag there to avoid uselessly updating all the images in the first frame.
This doesn't work and generates an error for every image: Warn: DEBUG_TYPE_ERROR: severity: high msg: GL_INVALID_OPERATION error generated. Texture is immutable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.