Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get_predictions on QueryResult #494

Closed
wants to merge 17 commits into from
Closed

Added get_predictions on QueryResult #494

wants to merge 17 commits into from

Conversation

jinensetpal
Copy link
Collaborator

Created a get_predictions function that:

  1. Loads a model registered with DagsHub-hosted MLFlow
  2. Locally performs inference on it and either appends to a column, and/or returns it for further use.

@jinensetpal jinensetpal added the enhancement New feature or request label Jul 1, 2024
@jinensetpal jinensetpal requested a review from kbolashev July 1, 2024 12:30
@jinensetpal jinensetpal self-assigned this Jul 1, 2024
@kbolashev
Copy link
Member

kbolashev commented Jul 1, 2024

Can you redo the linter/long-lines commits with line length set to 120, please?
Too many changes, which tells me that it was probably done with 80.

What are you using to format?
If it's black, rerun it with --line-length 120 (AFTER you roll back the commits)

I hope to move to pyproject.toml one day so I can keep this consistent :)

@jinensetpal
Copy link
Collaborator Author

On it!

@jinensetpal
Copy link
Collaborator Author

Interesting note, black does not format comments if they are over the length limit, but flake8 raises issues. What's the preferred approach?

@kbolashev
Copy link
Member

kbolashev commented Jul 1, 2024

Interesting note, black does not format comments if they are over the length limit, but flake8 raises issues. What's the preferred approach?

I just line break them manually, so it makes sense logically.
I switched from black+flake8 to ruff recently, it's a lot faster so I usually get complaints about long line lengths immediately. But it also doesn't break comments

dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
jinensetpal and others added 3 commits July 2, 2024 10:09
Co-authored-by: Kirill Bolashev <[email protected]>
manual configuration was effectively re-writing 'dagshub.init'
Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, thank you for taking time to do the progress bar!

dagshub/data_engine/model/query_result.py Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
@jinensetpal jinensetpal requested a review from kbolashev July 3, 2024 16:16
Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last little thing and we can merge it. Thank you!!!

dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
@jinensetpal
Copy link
Collaborator Author

Thank you for being so thorough!

@jinensetpal jinensetpal requested a review from kbolashev July 8, 2024 04:14
Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Jinen!! 🔥

@kbolashev
Copy link
Member

Closing as this is part of #513

@kbolashev kbolashev closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants