Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created generic prediction + annotation mechanism #571

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

jinensetpal
Copy link
Collaborator

@jinensetpal jinensetpal commented Dec 30, 2024

Decomposes predict_with_mlflow and annotate_with_mlflow for users that have custom inference functions / already saved annotations (and don't want to re-generate it lazily), as a generic function that returns annotations given batched requests.

  • minor code resilience, docstrings, requirements updates

@jinensetpal jinensetpal self-assigned this Dec 30, 2024
Copy link

dagshub bot commented Dec 30, 2024

Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks interesting!

The linter is failing on line lengths. Also please build docs and check how the functions end up looking for you in there.

requirements-dev.txt Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
@jinensetpal jinensetpal requested a review from kbolashev January 6, 2025 13:30
Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little bit left, thank you!

dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
dagshub/data_engine/model/query_result.py Outdated Show resolved Hide resolved
@jinensetpal jinensetpal requested a review from kbolashev January 6, 2025 17:41
Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kbolashev kbolashev merged commit dea8ba0 into master Jan 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants