Release 0.6.0 #30
Open
Release 0.6.0 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harvimt
commented
Sep 16, 2017
•
harvimt
commented
- utf8 UTF-8 issues #21 Non-ASCII characters get scrambled #18
- decompile on windows
- create output directory if it does not exist [FR] Create new directory if directory our HTML file is being output to does not exist #29
- support backslashes (\) correctly in story_data
I'm not sure why the decompiler was disabled on windows, it works just fine. The only reason I can think of is that it requires nokogiri which is a C extension, but the dep on nokogiri isn't exempted, so windows users who did `gem install twee2` were getting it anyway. Additionally, there are precompiled versions of nokogiri available for windows now, so you don't need a C compiler. Furthermore, RubyInstaller can install the C compilers now.
Ruby's gsub method is a little weird in how it handles substitution strings and there's no way to turn it off. I could escape the substitution string, but the translation is something like backslash followed by a number, & or single quote something like: def escape_sub(s) s.gsub(/\\[0-9&']/, '\\\&'); end this way strikes me as easier to reason about (though not necessarily any less convoluted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.